From 11d6183d65054c17c0e7cad54a476c0a945c41c3 Mon Sep 17 00:00:00 2001 From: Frederik Jaeckel Date: Sun, 15 Jan 2023 11:03:50 +0100 Subject: [PATCH] line: omit calculation of balance if credit/debit = None remove unused imports --- line.py | 7 ++++++- view/line_list.xml | 1 - wizard_booking.py | 3 +-- wizard_booking.xml | 2 +- wizard_openline.py | 2 +- wizard_openline.xml | 2 +- wizard_runreport.py | 5 ++--- wizard_runreport.xml | 2 +- 8 files changed, 13 insertions(+), 11 deletions(-) diff --git a/line.py b/line.py index 7c877bc..3031fea 100644 --- a/line.py +++ b/line.py @@ -733,7 +733,12 @@ class Line(SecondCurrencyMixin, Workflow, ModelSQL, ModelView): lines = Line2.search(query) for line3 in lines: - balance += getattr(line3, credit_name) - getattr(line3, debit_name) + line_credit = getattr(line3, credit_name) + line_debit = getattr(line3, debit_name) + + if (line_credit is not None) or (line_debit is not None): + balance += line_credit - line_debit + if line3.id == line.id: break return balance diff --git a/view/line_list.xml b/view/line_list.xml index 9bef16b..fffc0ac 100644 --- a/view/line_list.xml +++ b/view/line_list.xml @@ -13,6 +13,5 @@ full copyright notices and license terms. --> -